300 Make the ReadStreamSubscriber serialized #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsRenaud
force-pushed
the
300_serializable_ReadstreamInputStream
branch
from
0fac755
to
02e1ec7
Compare
|
( I originally signed off the commit with the wrong mail... this is fixed, how can I relaunch the legal check ><') |
vietj
reviewed
Jan 19, 2024
Ensure the ReadStream handler is never called concurrently. Note: The Rx1 implementation is different because such stack are possible: ``` at io.vertx.rx.java.ReadStreamSubscriber.onNext(ReadStreamSubscriber.java:244) <-- won't emit its element since `emitting == true` at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:134) at rx.internal.operators.OnSubscribeFromIterable$IterableProducer.slowPath(OnSubscribeFromIterable.java:117) at rx.internal.operators.OnSubscribeFromIterable$IterableProducer.request(OnSubscribeFromIterable.java:89) at rx.Subscriber.request(Subscriber.java:157) at io.vertx.rx.java.ReadStreamSubscriber.lambda$checkStatus$3(ReadStreamSubscriber.java:175) at io.vertx.rx.java.ReadStreamSubscriber.checkStatus(ReadStreamSubscriber.java:190) at io.vertx.rx.java.ReadStreamSubscriber.serializedCheckStatus(ReadStreamSubscriber.java:115) <-- Set `emitting = true` at io.vertx.rx.java.ReadStreamSubscriber.handler(ReadStreamSubscriber.java:70) ``` Signed-off-by: Nils Renaud <renaud.nils@gmail.com> Signed-off-by: Nils Renaud <nils.renaud@forgerock.com>
NilsRenaud
force-pushed
the
300_serializable_ReadstreamInputStream
branch
from
02e1ec7
to
9ba87cb
Compare
|
cc @jponge |
|
I will have a look
…On Mon, Jan 22, 2024 at 4:39 PM Julien Viet ***@***.***> wrote:
cc @jponge <https://github.com/jponge>
—
Reply to this email directly, view it on GitHub
<#304 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGK2J253KOFUERN4FBEL3YP2B3DAVCNFSM6AAAAABCBQJSCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGI3DOOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to this issue: #300
Ensure the ReadStream handler is never called concurrently.