Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Future<T> methods for 4.0 #109

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

okou19900722
Copy link
Contributor

@okou19900722 okou19900722 commented Oct 31, 2019

1, ProxyModel.check ReturnType allows to return the value of the Future type, Future's generic type is consistent with the AsyncResult's generic detection.
2, generate a method to return Future in *VertxEBProxy and *VertxProxyHandler
3, unit test
fix #107

@slinkydeveloper
Copy link
Member

@okou19900722 can you check why test fails?

slinkydeveloper added a commit to vert-x3/vertx-web that referenced this pull request Nov 14, 2019
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Member

slinkydeveloper commented Nov 14, 2019

I've adapted the code in vertx-web-api-service too vert-x3/vertx-web#1453, can you give a quick look at it too? If everything is fine, we merge 😄

@slinkydeveloper slinkydeveloper merged commit 3e6ee99 into vert-x3:master Nov 19, 2019
@slinkydeveloper
Copy link
Member

Done! Are you willing to do a pr to add docs too?

@okou19900722
Copy link
Contributor Author

I‘m so sorry. My English is not very good. In order not to produce misunderstood translations, it is best to write documents by others.

@slinkydeveloper
Copy link
Member

No problem, I'll do by myself. Thank you again for you contribution!

slinkydeveloper added a commit to vert-x3/vertx-web that referenced this pull request Dec 11, 2019
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit to vert-x3/vertx-web that referenced this pull request Jan 13, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit to vert-x3/vertx-web that referenced this pull request Jan 13, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit that referenced this pull request Jun 4, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper added a commit that referenced this pull request Jun 4, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@cvgaviao
Copy link
Contributor

cvgaviao commented Jun 5, 2020

Hey @slinkydeveloper, could you explain to me the reason for the future support revertion ?

@slinkydeveloper
Copy link
Member

The reason is that the feature was buggy and had different problems when used in conjunction with other vertx code generators (eg vertx rx generator).
Since we're in the process of releasing a new milestone, we decided to revert it in order to avoid releasing a buggy feature. We really think this is an important feature and we hope to redesign it properly for vertx 4 (suggestions welcome)

@cvgaviao
Copy link
Contributor

cvgaviao commented Jun 5, 2020

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it.
Seems that I'll be obligated to use my own branch built jar :(

@slinkydeveloper
Copy link
Member

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it.
Seems that I'll be obligated to use my own branch built jar :(

We're sorry for it :(, we hope to find a solution before vertx 4 final release

@vietj
Copy link
Contributor

vietj commented Jun 5, 2020 via email

@cvgaviao
Copy link
Contributor

cvgaviao commented Jun 8, 2020

I'm not using rxjava, and this was working nicely for me and currently, I have many services using it.
Seems that I'll be obligated to use my own branch built jar :(

We're sorry for it :(, we hope to find a solution before vertx 4 final release

Its ok, I was able to generate the necessary jars and published them to an internal repository in order to continue with our new project using future instead of a callback.

Btw, Its there issues created for those problems you have quoted above? If yes, could you point me to them?

@slinkydeveloper
Copy link
Member

Btw, Its there issues created for those problems you have quoted above? If yes, could you point me to them?

Lemme dump them in the #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Supporting Future<T> methods
4 participants