Replace ThreadLocals and add v thread ctx pooling #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vietj Still not sure about the added test: I was expecting it to cause some external unpark, while it doesn't seem the case |
in the new freshly created ctx
| @@ -97,38 +91,39 @@ public boolean isWorkerContext() { | |||
| private <T> void run(ContextInternal ctx, T value, Handler<T> task) { | |||
| Objects.requireNonNull(task, "Task handler must not be null"); | |||
| scheduler.execute(() -> { | |||
| inThread.set(true); | |||
| var current = Thread.currentThread(); | |||
| inThread.add(current); | |||
There was a problem hiding this comment.
I adopted this fix separately in my fork, it's an essential one
| @@ -32,17 +33,21 @@ public Async(Vertx vertx, boolean useVirtualEventLoopThreads) { | |||
| * Run a task on a virtual thread | |||
| */ | |||
| public void run(Handler<Void> task) { | |||
| assert !Thread.currentThread().isVirtual(); | |||
There was a problem hiding this comment.
I actually expect to be able to call .run from a virtual thread all the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.