Normalize line endings for comparing responses in tests #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmlopes
reviewed
Mar 29, 2017
| @@ -125,7 +125,7 @@ protected void testRequestBuffer(HttpClient client, HttpMethod method, int port, | |||
| latch.countDown(); | |||
| } else { | |||
| resp.bodyHandler(buff -> { | |||
| assertEquals(responseBodyBuffer, buff); | |||
| assertEquals(responseBodyBuffer, normalizeLineEndingsFor(buff)); | |||
There was a problem hiding this comment.
Sorry for being annoying :) what about having a flag to enable this on demand? For example if one is testing file downloads with binary payload this could again modify the payload.
There was a problem hiding this comment.
I can get testRequest (which takes in a string) to pass a boolean to testRequestBuffer. Unfortunately I have class and it will take a bit.
There was a problem hiding this comment.
I've revised the commit by adding a parameter that's only default true if a string-based testRequest is called.
This fixes most template engine tests failing on Windows. Only response bodies passed as strings will be normalized.
yunyu
force-pushed
the
normalize-line-endings-in-tests
branch
from
4e671c2
to
6c259b8
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most template engine tests failing on Windows if git autocrlf is enabled (default). Directly comparing the buffer strings broke the test, so I opted to normalize the buffer (adapted from Netty's LineBasedFrameDecoder) instead. I don't forsee any issues with this change, as different styles of line endings are irrelevant in tests anyways.