support ftp-urls in WebClient #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not quite finished, the solution is somewhat complicated since the url is parsed twice)
…o web-client-protocol
Signed-off-by: alexlehm <alexlehm@gmail.com>
tsegismont
reviewed
May 16, 2017
| URI uri = new URI(protocol, null, host, port, requestURI, null, null); | ||
| req = client.requestAbs(method, uri.toString()); | ||
| } catch (URISyntaxException ex) { | ||
| // FIXME: what is proper error handling? |
There was a problem hiding this comment.
This looks like the right way to handle the error to me.
| import io.vertx.ext.unit.junit.VertxUnitRunner; | ||
|
|
||
| /** | ||
| * |
remove empty comment from unit test class Signed-off-by: alexlehm <alexlehm@gmail.com>
|
@tsegismont actually test unit test isn't really useful as it relies on Squid running on the same machine, if we want to test it, we need a fake proxy as in core http tests |
|
IIRC the core build produces a jar with tests. Is the fake proxy an
internal class? Could it be made reusable?
2017-05-16 22:48 GMT+02:00 Alexander Lehmann <notifications@github.com>:
… @tsegismont <https://github.com/tsegismont> actually test unit test isn't
really useful as it relies on Squid running on the same machine, if we want
to test it, we need a fake proxy as in core http tests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbltskAkpcmvFRphj0tUiR97iSVHisRks5r6gumgaJpZM4NYogO>
.
|
Signed-off-by: alexlehm <alexlehm@gmail.com>
|
turns out that is already available since WebClientTest extends HttpTestBase from vertx-core |
Signed-off-by: alexlehm <alexlehm@gmail.com>
|
LGTM. Thanks @alexlehm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add same url handling to WebClient for ftp-urls as was added to vertx-core in the pr eclipse-vertx/vert.x#1959
the code probably needs some improvements, e.g. constructing the url with a URL constructor instead of creating the String directly