-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ftp-urls in WebClient #625
Conversation
(not quite finished, the solution is somewhat complicated since the url is parsed twice)
…o web-client-protocol
Signed-off-by: alexlehm <alexlehm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you remove the empty Javadoc block in the test?
URI uri = new URI(protocol, null, host, port, requestURI, null, null); | ||
req = client.requestAbs(method, uri.toString()); | ||
} catch (URISyntaxException ex) { | ||
// FIXME: what is proper error handling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the right way to handle the error to me.
import io.vertx.ext.unit.junit.VertxUnitRunner; | ||
|
||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ?
remove empty comment from unit test class Signed-off-by: alexlehm <alexlehm@gmail.com>
@tsegismont actually test unit test isn't really useful as it relies on Squid running on the same machine, if we want to test it, we need a fake proxy as in core http tests |
IIRC the core build produces a jar with tests. Is the fake proxy an
internal class? Could it be made reusable?
2017-05-16 22:48 GMT+02:00 Alexander Lehmann <notifications@github.com>:
… @tsegismont <https://github.com/tsegismont> actually test unit test isn't
really useful as it relies on Squid running on the same machine, if we want
to test it, we need a fake proxy as in core http tests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABbltskAkpcmvFRphj0tUiR97iSVHisRks5r6gumgaJpZM4NYogO>
.
|
Signed-off-by: alexlehm <alexlehm@gmail.com>
turns out that is already available since WebClientTest extends HttpTestBase from vertx-core |
Signed-off-by: alexlehm <alexlehm@gmail.com>
LGTM. Thanks @alexlehm |
add same url handling to WebClient for ftp-urls as was added to vertx-core in the pr eclipse-vertx/vert.x#1959
the code probably needs some improvements, e.g. constructing the url with a URL constructor instead of creating the String directly