Disallow regular user from adding trigger or cron job. #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisig0th
reviewed
Sep 23, 2019
|
no.
…On Mon, Sep 23, 2019 at 11:08 AM invisig0th ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In synapse/tests/test_lib_trigger.py
<#1380 (comment)>
:
> # Trigger list other user
self.len(0, await fred.listTriggers())
+ await self.asyncraises(
any reason this can't be just with self.raises() ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1380?email_source=notifications&email_token=AA3URJ7GY4C3MB73JEBRIH3QLDLVHA5CNFSM4IY3HCR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFSULKI#pullrequestreview-291849641>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3URJZS2NBTZEHBJ7XQS6DQLDLVHANCNFSM4IY3HCRQ>
.
|
Codecov Report
@@ Coverage Diff @@
## master #1380 +/- ##
==========================================
- Coverage 95.18% 92.69% -2.49%
==========================================
Files 133 133
Lines 19114 19120 +6
==========================================
- Hits 18193 17724 -469
- Misses 921 1396 +475
Continue to review full report at Codecov.
|
invisig0th
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a behavior change. Before, regular users could create automation and manipulate their own automations. Now, they need specific permissions to create automation.