Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model additions to represent education and awards and risk additions #1930

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1930 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
- Coverage   96.69%   96.45%   -0.24%     
==========================================
  Files         139      139              
  Lines       26513    26513              
==========================================
- Hits        25636    25574      -62     
- Misses        877      939      +62     
Flag Coverage Δ
#linux 96.45% <ø> (-0.24%) ⬇️
#linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/inet.py 99.28% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/person.py 100.00% <ø> (ø)
synapse/models/risk.py 100.00% <ø> (ø)
synapse/lib/spawn.py 89.10% <0.00%> (-6.42%) ⬇️
synapse/tests/utils.py 93.56% <0.00%> (-2.20%) ⬇️
synapse/cortex.py 95.19% <0.00%> (-0.82%) ⬇️
synapse/lib/hiveauth.py 95.96% <0.00%> (-0.77%) ⬇️
synapse/lib/view.py 95.29% <0.00%> (-0.75%) ⬇️
synapse/lib/link.py 98.00% <0.00%> (-0.67%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d804f5...7724748. Read the comment docs.

@invisig0th invisig0th changed the title WIP: Model additions to represent education and awards Model additions to represent education and awards and risk additions Oct 27, 2020
synapse/models/person.py Outdated Show resolved Hide resolved
Copy link
Contributor

@therealsilence therealsilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos/spelling

synapse/models/orgs.py Outdated Show resolved Hide resolved
synapse/models/person.py Outdated Show resolved Hide resolved
@invisig0th invisig0th merged commit 9cfd3f9 into master Oct 27, 2020
@invisig0th invisig0th deleted the visi-model-edu branch October 27, 2020 18:30
@vEpiphyte vEpiphyte added this to the 2.10.0 milestone Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants