Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for overzealous if condition caching in storm #2442

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2442 (e4f6298) into master (e23af7a) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2442      +/-   ##
==========================================
- Coverage   97.12%   97.00%   -0.12%     
==========================================
  Files         191      191              
  Lines       35619    35616       -3     
==========================================
- Hits        34596    34551      -45     
- Misses       1023     1065      +42     
Flag Coverage Δ
linux 97.00% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.36% <100.00%> (-0.01%) ⬇️
synapse/tests/utils.py 93.99% <0.00%> (-2.05%) ⬇️
synapse/lib/hiveauth.py 96.22% <0.00%> (-0.72%) ⬇️
synapse/lib/view.py 93.91% <0.00%> (-0.71%) ⬇️
synapse/cortex.py 96.36% <0.00%> (-0.67%) ⬇️
synapse/lib/trigger.py 94.35% <0.00%> (-0.41%) ⬇️
synapse/lib/hive.py 98.07% <0.00%> (-0.25%) ⬇️
synapse/lib/layer.py 97.85% <0.00%> (-0.06%) ⬇️
synapse/lib/lmdbslab.py 99.71% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23af7a...e4f6298. Read the comment docs.

@vEpiphyte vEpiphyte added this to the v2.6x.x milestone Oct 29, 2021
@vEpiphyte vEpiphyte added the bug label Oct 29, 2021
@vEpiphyte vEpiphyte changed the title WIP Fix for overzealous if condition caching in storm Fix for overzealous if condition caching in storm Oct 29, 2021
@vEpiphyte vEpiphyte merged commit 2fc59c0 into master Oct 29, 2021
@vEpiphyte vEpiphyte deleted the visi-ifcond-fix branch October 29, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants