Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Storm function kwargs before converting #2685

Merged
merged 2 commits into from
May 18, 2022
Merged

Process Storm function kwargs before converting #2685

merged 2 commits into from
May 18, 2022

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented May 18, 2022

No description provided.

@vEpiphyte vEpiphyte added this to the v2.9x.x milestone May 18, 2022
@vEpiphyte vEpiphyte added the bug label May 18, 2022
invisig0th
invisig0th previously approved these changes May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2685 (57d231b) into master (1c96f96) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2685      +/-   ##
==========================================
- Coverage   97.01%   96.89%   -0.13%     
==========================================
  Files         206      206              
  Lines       39618    39617       -1     
==========================================
- Hits        38434    38385      -49     
- Misses       1184     1232      +48     
Flag Coverage Δ
linux 96.89% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 96.19% <100.00%> (-0.02%) ⬇️
synapse/tests/utils.py 94.21% <0.00%> (-1.98%) ⬇️
synapse/lib/hiveauth.py 95.37% <0.00%> (-0.69%) ⬇️
synapse/cortex.py 96.54% <0.00%> (-0.66%) ⬇️
synapse/lib/view.py 96.75% <0.00%> (-0.49%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/hive.py 98.07% <0.00%> (-0.25%) ⬇️
synapse/lib/layer.py 97.06% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c96f96...57d231b. Read the comment docs.

@Cisphyx Cisphyx merged commit 1f24bcf into master May 18, 2022
@Cisphyx Cisphyx deleted the kwargs-fix branch May 18, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants