Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust number regex in Storm grammar #2708

Merged
merged 13 commits into from Jun 3, 2022
Merged

Adjust number regex in Storm grammar #2708

merged 13 commits into from Jun 3, 2022

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jun 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #2708 (0fd4afc) into master (1c5d408) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   96.94%   96.84%   -0.11%     
==========================================
  Files         206      206              
  Lines       39903    39903              
==========================================
- Hits        38684    38644      -40     
- Misses       1219     1259      +40     
Flag Coverage Δ
linux 96.84% <ø> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 97.57% <ø> (ø)
synapse/lib/storm_format.py 100.00% <ø> (ø)
synapse/tests/utils.py 93.69% <0.00%> (-1.98%) ⬇️
synapse/cortex.py 96.61% <0.00%> (-0.55%) ⬇️
synapse/lib/hiveauth.py 95.54% <0.00%> (-0.52%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 96.92% <0.00%> (-0.33%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/layer.py 97.14% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5d408...0fd4afc. Read the comment docs.

@Cisphyx Cisphyx changed the title WIP: Adjust number regex in Storm grammar Adjust number regex in Storm grammar Jun 1, 2022
@Cisphyx Cisphyx merged commit 10e7b79 into master Jun 3, 2022
@Cisphyx Cisphyx deleted the adjust-number branch June 3, 2022 14:46
@vEpiphyte vEpiphyte added this to the v2.9x.x milestone Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants