Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add edge:add and edge:del as trigger conditions, resolves SYN-5974 (#3360)" #3388

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

vEpiphyte
Copy link
Contributor

This reverts commit 7bd4018.

This will be revised for the next release.

#3360

@vEpiphyte vEpiphyte added this to the v2.152.0 milestone Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0002641) 97.31% compared to head (da8fdfe) 97.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   97.31%   97.21%   -0.11%     
==========================================
  Files         230      230              
  Lines       47059    46896     -163     
==========================================
- Hits        45797    45589     -208     
- Misses       1262     1307      +45     
Flag Coverage Δ
linux 97.21% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
synapse/lib/cache.py 100.00% <100.00%> (ø)
synapse/lib/snap.py 95.97% <ø> (+0.14%) ⬆️
synapse/lib/storm.py 95.71% <ø> (ø)
synapse/lib/stormtypes.py 98.76% <ø> (-0.01%) ⬇️
synapse/lib/trigger.py 95.03% <100.00%> (-1.56%) ⬇️
synapse/lib/view.py 97.17% <ø> (-0.37%) ⬇️
synapse/models/syn.py 98.41% <ø> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte merged commit 519c894 into master Oct 17, 2023
5 checks passed
@vEpiphyte vEpiphyte deleted the revert-3360-trigger_edge_5974 branch October 17, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants