Improve performance of trim 68x on large strings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8d6022d9bf05275ac358ee735882682a1fc1b0d0
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
+ Coverage 92.94% 93.00% +0.05%
- Complexity 193 197 +4
============================================
Files 17 17
Lines 468 472 +4
Branches 34 35 +1
============================================
+ Hits 435 439 +4
Misses 24 24
Partials 9 9
Continue to review full report at Codecov.
|
brockn
changed the title
brockn
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large SQL statement, around 6000 lines.
Warmup 50K runs then each run 50K times:
Elapsed time trimEnd: 22064ms
Elapsed time trimEnd: 323ms