Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: route not found if you have folder with file under parameter #134

Closed
dom3lek opened this issue Jul 4, 2022 · 2 comments · Fixed by #138
Closed

fix: route not found if you have folder with file under parameter #134

dom3lek opened this issue Jul 4, 2022 · 2 comments · Fixed by #138
Assignees
@renancaraujo
Labels
bug Something isn't working as expected

Comments

@dom3lek
Copy link

dom3lek commented Jul 4, 2022 •
edited

Description

Basically, if you have nested folder including parameters the routes are not being found.

Steps To Reproduce

  1. Create simple structure: test/[id]/test2/index.dart
  2. Try to execute the call, the route will not be found.

Expected Behavior

The route should be reachable as test/$id/test2 and test/$id/test2/

Additional Context

The problem does not appear if you put index.dart directly in [id] folder.
@dom3lek dom3lek added the bug Something isn't working as expected label Jul 4, 2022
renancaraujo added a commit that referenced this issue Jul 4, 2022
@renancaraujo
fix(#134): static dit inside dynamic dir
c2a9793
renancaraujo added a commit that referenced this issue Jul 4, 2022
@renancaraujo
fix(#134): static dir inside dynamic dir
c97cd0d
@renancaraujo renancaraujo mentioned this issue Jul 4, 2022
Closed
7 tasks
renancaraujo added a commit that referenced this issue Jul 4, 2022
@renancaraujo
fix(#134): static dir inside dynamic dir
e61a67e
renancaraujo added a commit that referenced this issue Jul 4, 2022
@renancaraujo
fix(#134): static dir inside dynamic dir
2c69c99
@renancaraujo renancaraujo self-assigned this Jul 4, 2022
@felangel felangel mentioned this issue Jul 4, 2022
Merged
7 tasks
@felangel
Copy link
Contributor

felangel commented Jul 4, 2022

@dom3lek this should be resolved in dart_frog_cli v0.0.2-dev.8

@dom3lek
Copy link
Author

dom3lek commented Jul 4, 2022

Thanks, I will give that try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renancaraujo renancaraujo

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dart_frog_gen): nested dynamic directory resolution VeryGoodOpenSource/dart_frog
3 participants
@renancaraujo @felangel @dom3lek