Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean the garbage after backup failed #27

Merged
merged 5 commits into from
Jan 26, 2022

Conversation

pengweisong
Copy link
Contributor

@pengweisong pengweisong commented Jan 26, 2022

  1. Add more readme for example.
  2. Cleanup the left snapshot files in system and external storage after backup failed.
  3. Improve show's error-handling.

@pengweisong
Copy link
Contributor Author

Please do not merge now, I need update the agent dependency after the nebula-agent pr is merged.

@pengweisong pengweisong changed the title Spw/fix s3 errors clean the garbage after backup failed Jan 26, 2022
critical27
critical27 previously approved these changes Jan 26, 2022
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

FangJinhe
FangJinhe previously approved these changes Jan 26, 2022
@pengweisong pengweisong dismissed stale reviews from FangJinhe and critical27 via 440eef0 January 26, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants