Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine meta backup and restore process of local storage #8

Merged
merged 14 commits into from
Jul 16, 2021
Merged

refine meta backup and restore process of local storage #8

merged 14 commits into from
Jul 16, 2021

Conversation

linkensphere201
Copy link
Contributor

@linkensphere201 linkensphere201 commented Jul 8, 2021 •
edited

this pr includes:

  • meta backup and restore process of local storage refinement: fix restore failed for multiple meta service in local storage.
  • add an option of backup command to show more information: now we can run with --verbose to show backup information.
  • add some unit tests

@linkensphere201
storage local: refine meta backup & restore workflow, now we would up…
8b19936 
…load meta's backup ssts to the client location, together with the generated meta file.

verbose: add an option `--verbose` for backup to show more information.
add some unit tests for ssh & utils mod.
@linkensphere201
remove decrecated option
35e3ec5
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

bright-starry-sky
bright-starry-sky reviewed Jul 9, 2021
View reviewed changes
pkg/storage/storage.go
Comment on lines +13 to +14
SCHEME_OSS = "oss"
SCHEME_S3 = "s3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already support OSS and S3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now oss and s3 are at experimental stage, would be ready at next version. I'll mark that.

@bright-starry-sky
Copy link
Contributor

One question , if SSH unencrypting fails, this command will always retry?

@linkensphere201
Copy link
Contributor Author

One question , if SSH unencrypting fails, this command will always retry?

Good catch, it seems so. I'll check that.

critical27
critical27 reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

pkg/backup/backup.go Outdated Show resolved Hide resolved
pkg/backup/backup.go Show resolved Hide resolved
pkg/backup/backup.go Show resolved Hide resolved
pkg/storage/local.go Show resolved Hide resolved
@linkensphere201
Copy link
Contributor Author

  • modified as review mentioned.
  • introduce a better operation to restore.
  • show subcommand bugfix.
  • add version infomation.

@linkensphere201
Copy link
Contributor Author

fix #10

@linkensphere201
Copy link
Contributor Author

  • fix 2 oss backend bugs

@linkensphere201 linkensphere201 merged commit 1f2be49 into vesoft-inc:master Jul 16, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 left review comments

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linkensphere201 @CLAassistant @bright-starry-sky @critical27