Add more datetime literal format. (#589)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
vesoft-inc · Jul 26, 2021 · 3b15cac · 3b15cac
1 parent c3d7959
commit 3b15cac
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/common/time/TimeUtils.h b/src/common/time/TimeUtils.h
@@ -9,6 +9,7 @@
 
 #include <iomanip>
 #include <limits>
+#include <sstream>
 #include <vector>
 
 #include "common/base/Status.h"
@@ -50,7 +51,11 @@ class TimeUtils {
         std::istringstream ss(str);
         ss >> std::get_time(&tm, "%Y-%m-%dT%H:%M:%S");
         if (ss.fail()) {
-            return Status::Error();
+            std::istringstream ss2(str);
+            ss2 >> std::get_time(&tm, "%Y-%m-%d %H:%M:%S");
+            if (ss2.fail()) {
+                return Status::Error();
+            }
         }
         DateTime dt;
         dt.year = tm.tm_year + 1900;

diff --git a/src/common/time/test/TimeUtilsTest.cpp b/src/common/time/test/TimeUtilsTest.cpp
@@ -163,6 +163,20 @@ TEST(Time, TimezoneShift) {
     }
 }
 
+TEST(Time, Parse) {
+    // datetime
+    {
+        auto result = time::TimeUtils::parseDateTime("2019-03-04 22:00:30");
+        ASSERT_TRUE(result.ok());
+        EXPECT_EQ(result.value(), DateTime(2019, 3, 4, 22, 0, 30, 0));
+    }
+    {
+        auto result = time::TimeUtils::parseDateTime("2019-03-04T22:00:30");
+        ASSERT_TRUE(result.ok());
+        EXPECT_EQ(result.value(), DateTime(2019, 3, 4, 22, 0, 30, 0));
+    }
+}
+
 }   // namespace nebula
 
 int main(int argc, char **argv) {