This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Replace unique_ptr with raw pointer in expression implementation #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
added
enhancement
Type: make the code neat or more efficient
wip
Solution: work in progress
do not review
PR: not ready for the code review yet
labels
May 27, 2021
The raw pointer is too implicit for the lifetime management. You could force everyone remember all object in expression is managed by objpool, but when these object referenced by other or passed from others it's more confuse. |
Aiee
force-pushed
the
refactor-expression
branch
3 times, most recently
from
June 2, 2021 07:13
ac74ebd
to
5e3d68b
Compare
Aiee
force-pushed
the
refactor-expression
branch
3 times, most recently
from
June 2, 2021 17:00
10a3920
to
349c938
Compare
Aiee
removed
do not review
PR: not ready for the code review yet
wip
Solution: work in progress
labels
Jun 2, 2021
Aiee
changed the title
[WIP] Replace unique_ptr with raw pointer in expression implementation
Replace unique_ptr with raw pointer in expression implementation
Jun 4, 2021
Aiee
force-pushed
the
refactor-expression
branch
3 times, most recently
from
June 10, 2021 02:13
c42e383
to
6c4516b
Compare
czpmango
reviewed
Jun 11, 2021
czpmango
reviewed
Jun 11, 2021
czpmango
reviewed
Jun 11, 2021
After off-line discussion, this scenario could be solved by changing all expression-related members from |
Aiee
force-pushed
the
refactor-expression
branch
from
June 15, 2021 03:17
6c4516b
to
d9a2d97
Compare
Aiee
force-pushed
the
refactor-expression
branch
3 times, most recently
from
June 23, 2021 13:04
20c279b
to
0b15f5d
Compare
Aiee
added
the
incompatible
PR: incompatible with the master branches in the storage or common repos
label
Jun 24, 2021
…on, ColumnExpression, ConstantExpression, ContainerExpression
…ssion, ColumnExpression, ConstantExpression, ContainerExpression
Aiee
force-pushed
the
refactor-expression
branch
from
June 28, 2021 09:35
40cb8c2
to
09a469f
Compare
CPWstatic
previously approved these changes
Jun 28, 2021
Clean up lambda capture
Aiee
force-pushed
the
refactor-expression
branch
from
June 28, 2021 12:17
09a469f
to
f3f550e
Compare
CPWstatic
approved these changes
Jun 28, 2021
yixinglu
reviewed
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ltgm
yixinglu
approved these changes
Jun 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: