This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Slow query. #565
Merged
Slow query. #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
force-pushed
the
slow_query
branch
2 times, most recently
from
cedfaa2
to
28ffc85
Compare
yixinglu
reviewed
Jun 29, 2021
| @@ -1063,6 +1063,20 @@ struct ListFTIndexesResp { | |||
| 3: map<binary, FTIndex> (cpp.template = "std::unordered_map") indexes, | |||
| } | |||
|
|
|||
| enum QueryStatus { | |||
There was a problem hiding this comment.
Seems no difference between these two words? Besides we have a lot struct defined as Status now.
src/common/interface/meta.thrift
Outdated
| 2: QueryStatus status; | ||
| 3: i64 duration; | ||
| 4: binary query; | ||
| // The session might transfor between query engines, but the query do not, we must |
|
|
||
| struct QueryDesc { | ||
| 1: common.Timestamp start_time; | ||
| 2: QueryStatus status; |
| @@ -1063,6 +1063,20 @@ struct ListFTIndexesResp { | |||
| 3: map<binary, FTIndex> (cpp.template = "std::unordered_map") indexes, | |||
| } | |||
|
|
|||
| enum QueryStatus { | |||
| RUNNING = 0x01, | |||
| KILLING = 0x02, | |||
There was a problem hiding this comment.
do we not need a finished or stopped state?
There was a problem hiding this comment.
The finished queries will be removed.
| @@ -46,5 +46,6 @@ using ZoneID = int32_t; | |||
|
|
|||
| using SessionID = int64_t; | |||
|
|
|||
| using ExecutionPlanID = int64_t; | |||
There was a problem hiding this comment.
Query id is better than plan id.
There was a problem hiding this comment.
For compatibility considered, I want to keep the idea Query ID for now, since we might have a truly global unique query id in further future.
yixinglu
previously approved these changes
Jun 29, 2021
CPWstatic
added
ready-for-testing
Aiee
previously approved these changes
Jun 30, 2021
laura-ding
reviewed
Jun 30, 2021
src/common/session/SessionManager.h
Outdated
| @@ -0,0 +1,71 @@ | |||
| /* Copyright (c) 2018 vesoft inc. All rights reserved. | |||
|
|
||
| E_QUERY_NOT_FOUND = -2073, |
There was a problem hiding this comment.
need to add to nebula-common/src/common/graph/Response.h
laura-ding
previously approved these changes
Jun 30, 2021
Aiee
previously approved these changes
Jun 30, 2021
laura-ding
approved these changes
Jun 30, 2021
Aiee
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.