This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Support to get attribute of date/time/datetime. #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-ding
reviewed
Jul 20, 2021
laura-ding
previously approved these changes
Jul 21, 2021
yixinglu
previously approved these changes
Jul 28, 2021
yixinglu
reviewed
Jul 28, 2021
yixinglu
reviewed
Jul 28, 2021
| static Value getDateAttr(const Date &d, const std::string &prop) { | ||
| auto lowerProp = boost::algorithm::to_lower_copy(prop); | ||
| if (lowerProp == "year") { | ||
| return d.year; |
There was a problem hiding this comment.
Don't you need to cast the type here ?
There was a problem hiding this comment.
it's not same as above getDateTimeAttr function.
There was a problem hiding this comment.
The datetime is bitfield, so need cast to fit the Value constructor.
| static Value getTimeAttr(const Time &t, const std::string &prop) { | ||
| auto lowerProp = boost::algorithm::to_lower_copy(prop); | ||
| if (lowerProp == "hour") { | ||
| return t.hour; |
laura-ding
approved these changes
Jul 29, 2021
yixinglu
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't process the bad null different with null, they are all null in computation.