This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
fix and simplify SubscriptRangeExpression's eval() #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
approved these changes
Jul 26, 2021
Aiee
approved these changes
Jul 26, 2021
CPWstatic
pushed a commit
to CPWstatic/nebula-common
that referenced
this pull request
Aug 2, 2021
CPWstatic
added a commit
that referenced
this pull request
Aug 2, 2021
* Modify the return value of partId function (#591) * fix and simplify SubscriptRangeExpression's eval (#593) * Fix toInteger() (#595) * Fix toInteger/toFloat parsing string * Check toInteger() overflow when parsing string Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrong result:
[4]
proper result:
[4,5]