Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go-prompt #143

Merged
merged 1 commit into from
Nov 15, 2021
Merged

add go-prompt #143

merged 1 commit into from
Nov 15, 2021

Conversation

HarrisChu
Copy link
Contributor

@HarrisChu HarrisChu commented Nov 15, 2021 •
edited

add go-prompt, need improvement as below:

  1. ctrl+r , search in history.
  2. write history to writer interface
  3. add an error when type ctrl+d in Input()
2021-11-15.10.09.33.mov

@HarrisChu HarrisChu added the wip label Nov 15, 2021
@jievince
Copy link
Contributor

Well done! Keep working

@jievince
Copy link
Contributor

Doesn't it work well in docker?

@HarrisChu
Copy link
Contributor Author

Doesn't it work well in docker?

Yes

@jievince
Copy link
Contributor

It's ok to me. The history-related functions of go-prompt could be done in another PR.

@HarrisChu HarrisChu removed the wip label Nov 15, 2021
@jievince jievince merged commit ed3a140 into vesoft-inc:master Nov 15, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarrisChu @jievince