bugfix: fix coredump issue when future_execute() return network error #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: 修复future_execute()错误时,ExecutionResponse.spaceName == nullptr,直接解引用导致的coredump问题
bugfix: fix coredump issue when future_execute() return network error. In such case, ExecutionResponse.spaceName == nullptr。There is segment fault at SessionPool.cpp@line45 and line65。
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
segement fault:
full log:
coredump.log
source code:
根因 / root cause
Connection.cpp @ line145
How do you solve it?
增加 spaceName 非空判断,不无脑解引用
check
ExecutionResponse.spaceName
is nullptr before compared withconfig_.spaceName_
Special notes for your reviewer, ex. impact of this fix, design document, etc: