fix session error #124
Merged
fix session error #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shylock-Hg Could you help to review this PR? |
Shylock-Hg
reviewed
Sep 5, 2023
include/nebula/client/Session.h
Outdated
| @@ -110,6 +110,12 @@ class Session { | |||
| return toLocal(data, offsetSecs_); | |||
| } | |||
|
|
|||
| bool isSessionError(const ExecutionResponse &resp) { | |||
Shylock-Hg
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
When using session pool, we have added retryConnect() if connection was broken, but, there is still a problem.
When the session is invalid, the query will fail with the bad session even the user try to query more times, as session can not recover by itself now.
How do you solve it?
So, when the session is invalid, we can also try to recreate the session, and make sure all the session is valid in the session pool.