Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose playground for dashboard #65

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Jun 7, 2022

partially implement #63

For now, we make compose file build dashboard images either from the released tarball or from the current repo(for dev purposes).

In the future, we could introduce GH actions to build images and push to docker hub

@wey-gu wey-gu added the do not review PR: not ready for the code review yet label Jun 7, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Jun 7, 2022

I will test it and remove the do not review label then.

@wey-gu wey-gu removed the do not review PR: not ready for the code review yet label Jun 7, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Jun 7, 2022

Now it's tested fine.

@wey-gu wey-gu added the doc affected Solution: improvements or additions to documentation label Jun 7, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Jun 7, 2022

for documentation changes, just refer to the readme file, this playground is helping both testing users to play with a released version and dev users to set up a workable dashboard based on a working code base.

Copy link
Contributor

@xigongdaEricyang xigongdaEricyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx wey-gu a lot, it looks good to me

@xigongdaEricyang xigongdaEricyang merged commit d5bc7ba into vesoft-inc:master Jun 13, 2022
@wey-gu wey-gu deleted the docker-compose branch June 22, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected Solution: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants