Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update image to 2.6.2 #105

Merged
merged 1 commit into from
Jan 27, 2022
Merged

update image to 2.6.2 #105

merged 1 commit into from
Jan 27, 2022

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Jan 26, 2022

No description provided.

@wey-gu wey-gu requested a review from Aiee January 26, 2022 15:33
@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

This pr will also help docker desktop 4.3.0+ from crashing graphD

@wey-gu wey-gu requested a review from HarrisChu January 27, 2022 06:16
@HarrisChu
Copy link
Contributor

I think it would be confused, why branch is 2.6.0 and image version is 2.6.2?

@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

Sure, should we create a new branch instead?

And if we leave it unchanged, in a big chance, new users will use the 2.6.0 image even from the 2.6.2 documentation, when they are running it on 4.3.0 or newer docker desktop(linux VM is cgroupv2 based), graphD will crash as RAM Utils assumed OS are cgroupv1 😭, this will make fresh user down in their first expression.

What do you think @HarrisChu , please?

We may keep it as is(2.6.0 branch but with 2.6.2 image) to avoid doc change, but in the future, we may only create branches in x.y(3.0) instead of x.y.z(3.0.0) in nebula-docker-compose.

@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

Created a pr to guide user to find minor versions of images: #106

@HarrisChu
Copy link
Contributor

prefer 2.6 branch, and declare version variable in .env file, it's the latest nebula version by default.
but we have 2.0.1 branch before, may change a lot

@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

I will create 2.6 branch later and change all corresponding parts(readme, documentations), later

@wey-gu wey-gu changed the base branch from v2.6.0 to v2.6 January 27, 2022 08:36
@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

@HarrisChu v2.6 is with the same base of v2.6.0 now and the pr was requested to v2.6 now.

I will update the master README after this is merged.

@HarrisChu HarrisChu merged commit deba050 into v2.6 Jan 27, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Jan 27, 2022

left the image-v2.6.2 not being deleted as this temp branch was shared to a user for saving him from being crashed during docker desktop 4.3.0+ compose-up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants