Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in 3.deploy-nebula-graph-with-docker-compose.md #2630

Closed
wants to merge 1 commit into from

Conversation

Sajotim
Copy link

@Sajotim Sajotim commented Mar 8, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@abby-cyber
Copy link
Contributor

The result of 'docker-compose -d' varies depending on the installation directory. Thank you for your contribution anyway.
For the broken links, see #2651

@abby-cyber abby-cyber closed this Mar 13, 2023
@wey-gu
Copy link
Contributor

wey-gu commented Jan 17, 2024

Indeed, the naming rule might vary depending on different conditions, like @abby-cyber mentioned the folder name where the yaml file was placed, and compose version etc

Maybe we could add notes for user to hint(especially when they are about to copy commands or scripting to automate things based on naming convention rules).

cc @QingZ11 @abby-cyber

ref: https://stackoverflow.com/questions/69464001/docker-compose-container-name-use-dash-instead-of-underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants