Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reading config file from hdfs #106

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Nov 8, 2022

close #84

@codecov-commenter
Copy link

Codecov Report

Base: 55.67% // Head: 55.46% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (bbdb414) compared to base (b86efc5).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
- Coverage     55.67%   55.46%   -0.21%     
  Complexity       81       81              
============================================
  Files            17       17              
  Lines          1419     1426       +7     
  Branches        267      268       +1     
============================================
+ Hits            790      791       +1     
- Misses          489      494       +5     
- Partials        140      141       +1     
Impacted Files Coverage Δ
...la/com/vesoft/exchange/common/config/Configs.scala 61.55% <20.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HarrisChu HarrisChu merged commit 5879b25 into vesoft-inc:master Nov 9, 2022
@Nicole00 Nicole00 deleted the config branch November 9, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support the config file in hdfs
3 participants