Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove data count #138

Merged
merged 1 commit into from May 18, 2023
Merged

remove data count #138

merged 1 commit into from May 18, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented May 17, 2023

remove data count operation:

  1. to reduce the importing time, count will cost extra time.
  2. to fix the bug for streaming data source cannot be count.

wey-gu
wey-gu previously approved these changes May 17, 2023
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have reasons why removing it?

@Nicole00 Nicole00 changed the title remove data count cherrypick #139 & remove data count May 17, 2023
@Nicole00
Copy link
Contributor Author

Could we have reasons why removing it?

data importing is all map operations

  1. count will cause long time cost, because the data will be processed and write into Nebula util the count operation done.
  2. streaming data source cannot be count.

@Nicole00 Nicole00 changed the base branch from release-3.5 to master May 17, 2023 08:43
@Nicole00 Nicole00 dismissed wey-gu’s stale review May 17, 2023 08:43

The base branch was changed.

@Nicole00 Nicole00 changed the title cherrypick #139 & remove data count remove data count May 17, 2023
@wey-gu
Copy link
Contributor

wey-gu commented May 17, 2023

Could we have reasons why removing it?

data importing is all map operations

  1. count will cause long time cost, because the data will be processed and write into Nebula util the count operation done.
  2. streaming data source cannot be count.

Thanks!

@Nicole00 Nicole00 merged commit 001c308 into vesoft-inc:master May 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants