Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ssl for flink connector #36

Merged
merged 8 commits into from
Nov 18, 2021
Merged

support ssl for flink connector #36

merged 8 commits into from
Nov 18, 2021

Conversation

Nicole00
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #36 (7d355b4) into master (adb8352) will increase coverage by 0.05%.
The diff coverage is 39.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     39.62%   39.68%   +0.05%     
- Complexity      145      152       +7     
============================================
  Files            46       48       +2     
  Lines          1398     1469      +71     
  Branches        132      136       +4     
============================================
+ Hits            554      583      +29     
- Misses          791      833      +42     
  Partials         53       53              
Impacted Files Coverage Δ
...la/connection/NebulaStorageConnectionProvider.java 0.00% <0.00%> (ø)
...ebula/connection/NebulaMetaConnectionProvider.java 40.74% <18.75%> (-10.55%) ⬇️
...nk/connector/nebula/connection/SelfSignParams.java 33.33% <33.33%> (ø)
...bula/connection/NebulaGraphConnectionProvider.java 76.66% <50.00%> (-6.67%) ⬇️
...link/connector/nebula/connection/CASignParams.java 53.33% <53.33%> (ø)
...nnector/nebula/connection/NebulaClientOptions.java 89.87% <76.19%> (+8.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb8352...7d355b4. Read the comment docs.


private final SelfSignedSSLParam selfSignParam;
private final SelfSignParams selfSignParams;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one with SSL and another with not ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the caSSLSignParams to caSignParams.

@Nicole00 Nicole00 merged commit d7be86b into vesoft-inc:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants