Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Flink library and shade dependencies from the fat jar #79

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

linhr
Copy link
Contributor

@linhr linhr commented Nov 22, 2022

This is a reference implementation for the changes suggested in #78.

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@linhr linhr changed the title Remove the Flink library and shade dependencies from the flat jar Remove the Flink library and shade dependencies from the fat jar Nov 22, 2022
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Base: 61.59% // Head: 61.59% // No change to project coverage 👍

Coverage data is based on head (c339d1b) compared to base (a41a660).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #79   +/-   ##
=========================================
  Coverage     61.59%   61.59%           
  Complexity      291      291           
=========================================
  Files            52       52           
  Lines          1786     1786           
  Branches        166      166           
=========================================
  Hits           1100     1100           
  Misses          596      596           
  Partials         90       90           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit 0c8f5c0 into vesoft-inc:master Nov 24, 2022
@linhr linhr deleted the flat-jar-improvement branch November 30, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants