Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add session lock #162

Merged
merged 2 commits into from
Dec 2, 2021
Merged

add session lock #162

merged 2 commits into from
Dec 2, 2021

Conversation

HarrisChu
Copy link
Contributor

as connection is not goroutine safe, if using the same session in two goroutine would cause error:
short write
just add a session lock.

Aiee
Aiee reviewed Dec 2, 2021
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
Aiee
Aiee approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Aiee Aiee merged commit 804d6d3 into vesoft-inc:master Dec 2, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

Assignees
No one assigned
Labels
ready for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarrisChu @Aiee