remove remote services, the code is not necessary to use this project as a nebula driver #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as a nebula driver
|
|
|
Hello @peczenyj, you are right that these files are not necessary to be there. Since the parent directories of these files contain only 1 file, maybe you can delete the directory as well to make it cleaner. |
|
Thanks a ton, @peczenyj ! |
Cleaned and Rebased |
* add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results
peczenyj
added a commit
to peczenyj/nebula-go
that referenced
this pull request
May 10, 2022
… as a nebula driver (vesoft-inc#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (vesoft-inc#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Closed
Aiee
added a commit
that referenced
this pull request
Jul 1, 2022
* update test to check ipv6 version of localhost * use net.JoinHostPort to handle the ipv6 case properly * remove remote services, the code is not necessary to use this project as a nebula driver (#200) * remove remote services, the code is not necessary to use this project as a nebula driver * Create integration tests (#201) * add build tag for integration tests * add unit rule to run unit tests * add unit as phony * improve formatting of each _test file, enable coverate on functional tests * add badge for test results Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
this patch should fix issue #199
as you can see, each deleted file is a specific program with a main function.
it is not necessary for this project IMHO
Best Regards
Tiago