Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone in path #258

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Fix timezone in path #258

merged 3 commits into from
Mar 3, 2023

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Mar 1, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #257

Description:

As title.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@Aiee Aiee added the type/bug Type: something is unexpected label Mar 1, 2023
@Aiee Aiee requested a review from veezhang March 1, 2023 11:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.01 🎉

Comparison is base (9d7c5fb) 62.27% compared to head (9baf378) 62.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   62.27%   62.29%   +0.01%     
==========================================
  Files           9        9              
  Lines        2269     2270       +1     
==========================================
+ Hits         1413     1414       +1     
  Misses        711      711              
  Partials      145      145              
Impacted Files Coverage Δ
value_wrapper.go 71.16% <ø> (ø)
result_set.go 61.56% <25.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aiee Aiee requested a review from HarrisChu March 2, 2023 02:38
@Aiee Aiee merged commit b304ce0 into vesoft-inc:master Mar 3, 2023
@Aiee Aiee deleted the fix-path-timezone branch March 3, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetime value in the path is not converted with the time zone specified
4 participants