Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet Scan supports more types #309

Merged
merged 2 commits into from Jan 31, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jan 31, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

@Nicole00 As discussed in #303 (comment).

I added the primitive types support in this PR, I think we can release a new version for the minimal feature of ResultSet.Scan now.

We can open an issue for the Date/Time/DateTime/Duration types support because we need some effort for that.

I created the issue #310

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (80a0c3f) 63.27% compared to head (9088138) 63.17%.

Files Patch % Lines
result_set.go 20.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   63.27%   63.17%   -0.10%     
==========================================
  Files           9        9              
  Lines        2456     2466      +10     
==========================================
+ Hits         1554     1558       +4     
- Misses        772      778       +6     
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins marked this pull request as ready for review January 31, 2024 05:38
@Nicole00 Nicole00 merged commit d0307aa into vesoft-inc:master Jan 31, 2024
20 checks passed
@haoxins haoxins deleted the feat-scan-more-types branch January 31, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants