Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplyEdge for SchemaManager #319

Merged
merged 2 commits into from Feb 23, 2024
Merged

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Feb 21, 2024

See also #317

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

wip

WIP

Update schema_manager_test.go

fix

fix
@haoxins
Copy link
Collaborator Author

haoxins commented Feb 21, 2024

Will do some code refactoring after this PR has been merged :)

@haoxins haoxins marked this pull request as draft February 21, 2024 09:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (2fd8560) 64.32% compared to head (7beef73) 64.73%.

Files Patch % Lines
schema_manager.go 74.07% 10 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   64.32%   64.73%   +0.41%     
==========================================
  Files          11       11              
  Lines        2643     2705      +62     
==========================================
+ Hits         1700     1751      +51     
- Misses        802      810       +8     
- Partials      141      144       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins marked this pull request as ready for review February 21, 2024 10:02
@wey-gu wey-gu requested a review from Nicole00 February 21, 2024 12:24
Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit 9bfafce into vesoft-inc:master Feb 23, 2024
23 checks passed
@haoxins haoxins deleted the apply-edge branch February 23, 2024 02:37
haoxins added a commit to haoxins/nebula-go that referenced this pull request Feb 23, 2024
* Add ApplyEdge

wip

WIP

Update schema_manager_test.go

fix

fix

* fix
haoxins added a commit to haoxins/nebula-go that referenced this pull request Feb 23, 2024
* Add ApplyEdge

wip

WIP

Update schema_manager_test.go

fix

fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants