Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddTagTTL and AddEdgeTTL for Session Pool #323

Merged
merged 1 commit into from Feb 29, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Feb 28, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 64.55%. Comparing base (5bfccb7) to head (56a5bbe).

Files Patch % Lines
session_pool.go 57.14% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   64.59%   64.55%   -0.04%     
==========================================
  Files          11       11              
  Lines        2723     2737      +14     
==========================================
+ Hits         1759     1767       +8     
- Misses        817      821       +4     
- Partials      147      149       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins haoxins force-pushed the pool-ttl branch 4 times, most recently from 711400b to 56a5bbe Compare February 28, 2024 07:47
@haoxins haoxins marked this pull request as ready for review February 28, 2024 07:55
@haoxins
Copy link
Collaborator Author

haoxins commented Feb 28, 2024

@Nicole00
Is there a way to check the TTL is set correctly?

@Nicole00
Copy link
Contributor

@Nicole00 Is there a way to check the TTL is set correctly?

you can set the TTL_DURATION 5 for tag , insert some vertex for this tag.
And query the vertex after 5 seconds, if query result is empty, then your TTL is set correctly.
https://docs.nebula-graph.com.cn/3.6.0/3.ngql-guide/8.clauses-and-options/ttl-options/#tag_edge_type

@haoxins haoxins force-pushed the pool-ttl branch 5 times, most recently from a716f97 to e4d3d73 Compare February 28, 2024 15:58
@haoxins
Copy link
Collaborator Author

haoxins commented Feb 28, 2024

it works now

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicole00 Nicole00 merged commit cefdede into vesoft-inc:master Feb 29, 2024
23 checks passed
@haoxins haoxins deleted the pool-ttl branch February 29, 2024 02:18
haoxins added a commit to haoxins/nebula-go that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants