Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Required python 3.7 for test framework #1108

Merged
merged 4 commits into from
Jun 23, 2021

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Jun 4, 2021

gherkin-format depends on python 3.8.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jun 4, 2021
@yixinglu yixinglu requested a review from a team June 4, 2021 02:48
tests/README.md Outdated Show resolved Hide resolved
laura-ding
laura-ding previously approved these changes Jun 4, 2021
nevermore3
nevermore3 previously approved these changes Jun 4, 2021
@yixinglu yixinglu dismissed stale reviews from nevermore3 and laura-ding via d994bed June 7, 2021 02:09
@yixinglu yixinglu changed the title Required python 3.8 for test framework Required python 3.7 for test framework Jun 7, 2021
jievince
jievince previously approved these changes Jun 12, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@yixinglu yixinglu requested a review from czpmango June 23, 2021 08:20
@yixinglu yixinglu merged commit 57ea810 into vesoft-inc:master Jun 23, 2021
@yixinglu yixinglu deleted the required-py3-version branch June 23, 2021 08:38
nevermore3 pushed a commit to nevermore3/nebula-graph that referenced this pull request Jun 24, 2021
* Required python 3.8 for test framework

* Make fail

* Check python version only for gherkin-format

* Move parser to end of file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants