This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
refactor go #1111
Merged
refactor go #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
force-pushed
the
refactor_go
branch
2 times, most recently
from
7c26f37
to
9185af5
Compare
nevermore3
force-pushed
the
refactor_go
branch
2 times, most recently
from
cff4376
to
7ab49db
Compare
nevermore3
added
ready-for-testing
CPWstatic
previously approved these changes
Jun 22, 2021
yixinglu
approved these changes
Jun 22, 2021
CPWstatic
approved these changes
Jun 22, 2021
nevermore3
added a commit
to nevermore3/nebula-graph
that referenced
this pull request
Jun 24, 2021
* refactor go * fix error * unify getNeighbors interface * fix compiler error * fix unit test * fix ci test error
This was referenced Jun 27, 2021
czpmango
reviewed
Aug 2, 2021
Comment on lines
+16
to
+27
| WHERE any(x in split($$.player.name, ' ') WHERE x contains 'Ti') | ||
| YIELD $$.player.name, like._dst AS vid | ||
| | GO FROM $-.vid OVER like BIDIRECT WHERE any(x in split($$.player.name, ' ') WHERE x contains 'Ti') | ||
| YIELD $$.player.name | ||
| """ | ||
| Then the result should be, in any order: | ||
| | $^.player.name | | ||
| | "Tiago Splitter" | | ||
| | $$.player.name | | ||
| | "Tim Duncan" | | ||
| And the execution plan should be: | ||
| | id | name | dependencies | operator info | | ||
| | 16 | Project | 26 | | | ||
| | 26 | LeftJoin | 25 | | | ||
| | 25 | Filter | 13 | | | ||
| | 13 | Project | 22 | | | ||
| | 22 | GetNeighbors | 9 | | | ||
| | 9 | Project | 24 | | | ||
| | 24 | LeftJoin | 23 | | | ||
| | 23 | Filter | 6 | | | ||
| | 6 | Project | 21 | | | ||
| | 21 | GetNeighbors | 2 | | | ||
| | 2 | Project | 17 | | | ||
| | 17 | IndexScan | 0 | | | ||
| | 22 | Project | 21 | | | ||
| | 21 | Filter | 20 | | |
There was a problem hiding this comment.
Why not add another test case instead of changing this?
This has compromised the test of the other code logic.
czpmango
reviewed
Aug 2, 2021
| @@ -60,7 +60,7 @@ TEST_F(QueryValidatorTest, GoZeroStep) { | |||
| "| GO FROM $-.id OVER serve"; | |||
| std::vector<PlanNode::Kind> expected = { | |||
| PK::kProject, | |||
| PK::kLeftJoin, | |||
| PK::kInnerJoin, | |||
There was a problem hiding this comment.
Why change LeftJoin to InnerJoin? Isn't the result different?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.