This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 132
Let the test cases reentrant. #1113
Merged
yixinglu
merged 6 commits into
vesoft-inc:master
from
Shylock-Hg:tests/let-test-reentrant
Jul 2, 2021
Merged
Let the test cases reentrant. #1113
yixinglu
merged 6 commits into
vesoft-inc:master
from
Shylock-Hg:tests/let-test-reentrant
Jul 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Jun 7, 2021
max_write_buffer_number=4} | ||
max_bytes_for_level_base="1024", | ||
write_buffer_size="1024", | ||
max_write_buffer_number="4"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why to use double quotes for config values? it's different from flags in cmdline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just string in the storage configuration file. https://github.com/vesoft-inc/nebula-storage/blob/c180a9a241767c312a50e6e64a341ef0e3f8a11e/conf/nebula-storaged.conf.production#L81
yixinglu
approved these changes
Jul 2, 2021
Aiee
approved these changes
Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.