Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

disable create space without vid_type #1129

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

czpmango
Copy link
Contributor

Fixes #1127

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Jun 11, 2021
@czpmango czpmango requested a review from a team June 11, 2021 07:51
@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the master branches in the storage or common repos label Jun 11, 2021
@Shylock-Hg
Copy link
Contributor

It's an incompatible modification.

@whitewum
Copy link
Contributor

what's the return if no vid specified. The return message will be asked many times.

@czpmango czpmango force-pushed the fix-create branch 2 times, most recently from b6ec454 to ab4362c Compare June 15, 2021 11:27
@laura-ding laura-ding added the doc affected Solution: improvements or additions to documentation label Jun 16, 2021
CPWstatic
CPWstatic previously approved these changes Jun 16, 2021
laura-ding
laura-ding previously approved these changes Jun 17, 2021
@czpmango
Copy link
Contributor Author

what's the return if no vid specified. The return message will be asked many times.

What do you mean by "The return message will be asked many times"?

@czpmango czpmango requested review from CPWstatic and a team June 17, 2021 08:07
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2021

CLA assistant check
All committers have signed the CLA.

@yixinglu yixinglu merged commit b8b830a into vesoft-inc:master Jun 21, 2021
nevermore3 pushed a commit to nevermore3/nebula-graph that referenced this pull request Jun 24, 2021
fix ut

add tck

format

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc affected Solution: improvements or additions to documentation incompatible PR: incompatible with the master branches in the storage or common repos ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Must specifies vid type explicitly when create space.
7 participants