Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Fix use same filters to lookup index #1213

Merged
merged 8 commits into from
Jul 13, 2021
Merged

Fix use same filters to lookup index #1213

merged 8 commits into from
Jul 13, 2021

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Jul 6, 2021

as title.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jul 6, 2021
Aiee
Aiee previously approved these changes Jul 12, 2021
View reviewed changes
CPWstatic
CPWstatic approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. We might need some UT for some of the utils.

@yixinglu yixinglu merged commit 85df822 into vesoft-inc:master Jul 13, 2021
@yixinglu yixinglu deleted the fix-column-hints branch July 13, 2021 08:22
@jamieliu1023 jamieliu1023 mentioned this pull request Jul 17, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@Aiee Aiee Aiee approved these changes

@czpmango czpmango Awaiting requested review from czpmango

@jievince jievince Awaiting requested review from jievince

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yixinglu @CPWstatic @Aiee