This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Refactor join. #1263
Closed
Refactor join. #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Jul 20, 2021
| std::string MatchedResult::toString() const { | ||
| std::stringstream ss; | ||
| std::queue<const MatchedResult*> queue; | ||
| std::unordered_set<const MatchedResult*> visited; |
There was a problem hiding this comment.
It seems that you can delete the visited variable.
| std::string Pattern::toString() const { | ||
| std::stringstream ss; | ||
| std::queue<const Pattern*> queue; | ||
| std::unordered_set<const Pattern*> visited; |
| const auto &pattern = this->pattern(); | ||
| auto status = pattern.match(groupNode); | ||
| NG_RETURN_IF_ERROR(status); | ||
| auto matched = std::move(status).value(); | ||
| if (!this->match(ctx, matched)) { | ||
| return Status::Error(); | ||
| } | ||
| VLOG(1) << "Hit rule: " + this->toString() | ||
| << " pattern: " << pattern.toString() | ||
| << " subtree of plan: " << matched.toString(); |
There was a problem hiding this comment.
could you cleanup these debug logs?
CPWstatic
force-pushed
the
refactor_join
branch
2 times, most recently
from
984b603
to
6b574f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.