Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Update README.md #1349

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update README.md #1349

merged 1 commit into from
Sep 3, 2021

Conversation

Sophie-Xie
Copy link
Contributor

  1. update for move repo.
  2. fix the logo.

@@ -33,6 +33,8 @@ Compared with other graph database solutions, **Nebula Graph** has the following

The Nebula Graph team is glad to announce the Nebula Graph 2.0.0 GA. This is a brand new start with several important updates, and more of them are on the way. Welcome to join us.

After v2.5.0, we use [Nebula repo](https://github.com/vesoft-inc/nebula).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the paragraph above this one and change "Nebula Graph 2.0.0 GA" to "Nebula Graph 2.5.0"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so if we want to keep the Notice of Release section. However, as a rule of thumb, I would not suggest we put such kind of notice in README because the versions are constantly evolving. It is just annoying that you have to update the version number every time there is a new release. People know where to find the latest version of the product. It just should NOT be a necessary part of a README file IMHO.

With that being said: 1) I agree we should update the version number here because this repo is not in use any more; 2) Let's remove the Notice of Release in the nebula repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I deleted this description in the readme of the nebula repo.

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Sep 3, 2021
@Shinji-IkariG Shinji-IkariG merged commit 74ebed9 into master Sep 3, 2021
@Shinji-IkariG Shinji-IkariG deleted the Sophie-Xie-patch-1 branch September 3, 2021 09:24
@HarrisChu HarrisChu mentioned this pull request Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picture of logo in readme is broken MD file description suggestion
5 participants