Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjustment log #53

Merged
merged 1 commit into from
Nov 11, 2021
Merged

adjustment log #53

merged 1 commit into from
Nov 11, 2021

Conversation

veezhang
Copy link
Contributor

@veezhang veezhang commented Nov 10, 2021 •
edited

  • use appname as the log file name
  • support log level config
  • beego's log functions is Deprecated: use github.com/astaxie/beego/logs instead.

hetao92
hetao92 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@hetao92 hetao92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MegaByte875
MegaByte875 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veezhang veezhang merged commit cce0022 into vesoft-inc:master Nov 11, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaByte875 MegaByte875 MegaByte875 approved these changes

@hetao92 hetao92 hetao92 approved these changes

@nianiaJR nianiaJR Awaiting requested review from nianiaJR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veezhang @MegaByte875 @hetao92