Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #159 add counting for read csv failed lines. #164

Merged
merged 2 commits into from
Sep 23, 2021
Merged

fix #159 add counting for read csv failed lines. #164

merged 2 commits into from
Sep 23, 2021

Conversation

IanSmith123
Copy link
Contributor

@IanSmith123 IanSmith123 commented Sep 22, 2021 •
edited by yixinglu
Loading

The importer doesn't save read csv failed lines currently.
This PR add StatsMgr.NumReadFailed for saving read failed lines and print failed count when import file finished.
image

fixes #159

@IanSmith123
Copy link
Contributor Author

image
I didn't meet this error when I ran docker-compose pull && make test on my local machine, so I'm still trying to find the causes of this error.

@IanSmith123
Copy link
Contributor Author

This error might relate to the proxy cache of nebula-go.

  1. When I ran make test with current ci/bootstrap.sh，I got the same error as github workflow.
  2. When I added go env -w GOPROXY=https://goproxy.io,direct to ci/bootstrap.sh to accelerate the speed of download files, it built success.

How to overcome this problem is still a question.
BTW, I met a watermark error when I ran make test，like the discussion in forum :)

yixinglu
yixinglu approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo! LGTM

@Aiee Aiee merged commit 6b70c0c into vesoft-inc:master Sep 23, 2021
@IanSmith123 IanSmith123 mentioned this pull request Sep 23, 2021
Closed
This was referenced Oct 20, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import result error
3 participants
@IanSmith123 @yixinglu @Aiee