Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS: fix the WithoutAuthentication option #290

Merged
merged 3 commits into from Sep 20, 2023

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Sep 13, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

When you run the application in the GCP ENVs, such as GKE or GCE.
The GCS client will try to get credentials underlying the ENVs.

See https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity

Unless the user specifies that, we shouldn't set the WithoutAuthentication option.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@veezhang
Copy link
Contributor

@haoxins Thanks!
Can you fix the testing ?
BTW, do you know which env has the effect?

@veezhang veezhang added the doc affected PR: improvements or additions to documentation label Sep 18, 2023
@haoxins
Copy link
Contributor Author

haoxins commented Sep 18, 2023

I need to find a solution to fix the test.
The test failed because it is not running on the GKE/GCE environment.

https://cloud.google.com/docs/authentication/application-default-credentials?hl=zh-cn#attached-sa

@veezhang
Copy link
Contributor

veezhang commented Sep 19, 2023

@haoxins Setting WithoutAuthentication to true may solve the problem.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1cbec84) 87.89% compared to head (feb24d8) 87.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files          79       79           
  Lines        3857     3857           
=======================================
  Hits         3390     3390           
  Misses        458      458           
  Partials        9        9           
Files Changed Coverage Δ
pkg/source/gcs.go 85.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haoxins
Copy link
Contributor Author

haoxins commented Sep 20, 2023

@haoxins Setting WithoutAuthentication to true may solve the problem.

fixed

@veezhang
Copy link
Contributor

@haoxins Thanks a lot!

@veezhang veezhang closed this Sep 20, 2023
@veezhang veezhang reopened this Sep 20, 2023
Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit bc8b40d into vesoft-inc:master Sep 20, 2023
3 checks passed
@haoxins haoxins deleted the feat/parquet branch September 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants