Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl support for graph daemon #364

Merged
merged 6 commits into from
Oct 13, 2021
Merged

add ssl support for graph daemon #364

merged 6 commits into from
Oct 13, 2021

Conversation

klay-ke
Copy link

@klay-ke klay-ke commented Oct 12, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #364 (f8d2ad9) into master (a19546e) will increase coverage by 1.17%.
The diff coverage is 83.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #364      +/-   ##
============================================
+ Coverage     61.68%   62.86%   +1.17%     
- Complexity      611      634      +23     
============================================
  Files            55       59       +4     
  Lines          2858     3024     +166     
  Branches        406      421      +15     
============================================
+ Hits           1763     1901     +138     
- Misses          819      837      +18     
- Partials        276      286      +10     
Impacted Files Coverage Δ
...com/vesoft/nebula/client/graph/net/Connection.java 100.00% <ø> (ø)
...vesoft/nebula/client/graph/net/ConnObjectPool.java 53.65% <60.00%> (-0.40%) ⬇️
...vesoft/nebula/client/graph/net/SyncConnection.java 53.46% <66.66%> (+5.52%) ⬆️
.../src/main/java/com/vesoft/nebula/util/SslUtil.java 81.91% <81.91%> (ø)
...m/vesoft/nebula/client/graph/NebulaPoolConfig.java 100.00% <100.00%> (ø)
...oft/nebula/client/graph/data/CASignedSSLParam.java 100.00% <100.00%> (ø)
.../com/vesoft/nebula/client/graph/data/SSLParam.java 100.00% <100.00%> (ø)
...t/nebula/client/graph/data/SelfSignedSSLParam.java 100.00% <100.00%> (ø)
...com/vesoft/nebula/client/graph/net/NebulaPool.java 91.00% <100.00%> (+0.18%) ⬆️
...ebula/client/graph/net/RoundRobinLoadBalancer.java 95.91% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19546e...f8d2ad9. Read the comment docs.

@darionyaphet
Copy link
Contributor

I recommend submitting thrift generated code separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants