Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the connection's status when borrow and return #503

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Dec 29, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fix #401

Description:

How do you solve it?

related pr #400, thanks @vchangpengfei for proposing the issue and pr.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@codecov-commenter
Copy link

Codecov Report

Base: 63.46% // Head: 63.77% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (b504b45) compared to base (e25c56d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #503      +/-   ##
============================================
+ Coverage     63.46%   63.77%   +0.31%     
- Complexity      787      792       +5     
============================================
  Files            71       71              
  Lines          3758     3760       +2     
  Branches        537      537              
============================================
+ Hits           2385     2398      +13     
+ Misses         1004      994      -10     
+ Partials        369      368       -1     
Impacted Files Coverage Δ
...com/vesoft/nebula/client/graph/net/NebulaPool.java 87.27% <100.00%> (+0.23%) ⬆️
...vesoft/nebula/client/graph/net/ConnObjectPool.java 56.09% <0.00%> (+2.43%) ⬆️
...java/com/vesoft/nebula/client/meta/MetaClient.java 57.69% <0.00%> (+4.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set default check the connection to fix the error like 'IOErrorException: Cannot write to null outputStream'
3 participants