Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage address mapping transform #589

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

awang12345
Copy link
Contributor

@awang12345 awang12345 commented Feb 1, 2024

What type of PR is this?

  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

When scanning with storageClient, the storage address obtained from meta may not be used directly, such as 127.0.0.1. The code executed must be used with the storage service, but often the business code and the nebula server are not on the same machine or the same network segment. This results in the inability to scan the data using storageClient

How do you solve it?

StorageClient initializes the Address translation relationship, and then MateManger returns address translation

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Because of runing the local nebula-client exception, the code did not run the unit tests

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

@Nicole00
Copy link
Contributor

Nicole00 commented Jul 1, 2024

@awang12345 Hi, I am advancing this PR, can you confirm your email and sign the following cla for jiangyiwang-jk?

@awang12345
Copy link
Contributor Author

@awang12345 Hi, I am advancing this PR, can you confirm your email and sign the following cla for jiangyiwang-jk?

The name jiangyiwang-jk is wrong.The correct name is wang12345

@awang12345
Copy link
Contributor Author

@awang12345 Hi, I am advancing this PR, can you confirm your email and sign the following cla for jiangyiwang-jk?

I don't know how to change this wrong name

@Nicole00
Copy link
Contributor

Nicole00 commented Jul 4, 2024

@awang12345 Hi, I am advancing this PR, can you confirm your email and sign the following cla for jiangyiwang-jk?

I don't know how to change this wrong name

Don't worry, the cla has passed.

@Nicole00 Nicole00 merged commit cd003d5 into vesoft-inc:master Jul 5, 2024
2 checks passed
Nicole00 added a commit that referenced this pull request Jul 8, 2024
Nicole00 added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants