support component customize the nodeSelector #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqzh
reviewed
Oct 9, 2021
| @@ -41,6 +41,7 @@ type NebulaClusterComponentter interface { | |||
| GetPodEnvVars() []corev1.EnvVar | |||
| GetPodAnnotations() map[string]string | |||
| GetPodLabels() map[string]string | |||
| NodeSelector() map[string]string | |||
There was a problem hiding this comment.
rename NodeSelector() to GetNodeSelector() ?
There was a problem hiding this comment.
I think the func name with a prefix verb "get" is not needed, this is a common property of component, what do you think?
There was a problem hiding this comment.
ok, in that case, we also need rename other func name of prefix verb "get" in componentter soon
kqzh
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.